Updated support for rhsm builds of rhosp17 on rhel9 #209
Conversation
| @@ -113,7 +113,7 @@ | |||
| stdin: "{{ network_state | to_nice_json }}" | |||
| vars: | |||
| network_state: | |||
| interfaces: "{{ nmstate_ifs }}" | |||
| interfaces: "{{ nmstate_ifs | from_yaml }}" | |||
There was a problem hiding this comment.
I've tested RHEL 9.2 and OSP 17.1 and this wasn't needed.
There was a problem hiding this comment.
Without that, this fails when deploying on kvm/libvirt.
There was a problem hiding this comment.
rhel 9.0 on OSP17.0
| when: | ||
| - ansible_facts.distribution_major_version == "9" | ||
| ansible.builtin.set_fact: | ||
| checkpoint: "{{ (nmstateset.stderr_lines | last).split()[-1] }}" | ||
| checkpoint: "{{ (nmstateset.stdout_lines | select('search', 'Checkpoint: NetworkManager\\|') | last).split()[1] }}" |
There was a problem hiding this comment.
I've tested RHEL 9.2 and OSP 17.1 and this wasn't needed.
There was a problem hiding this comment.
regarding the change to Set fact for nmstate checkpoint on RHEL9, this was required when i did a clean install of OSP 17.0 on RHEL9.0
it was not required on centos stream
it seems particular to 17.0 on RHEL9
There was a problem hiding this comment.
ack, will have to test it on RHEL 8.4 and RHEL 9.2 too to make sure it's compatible.
There was a problem hiding this comment.
I have added handlers for rhel 9.0 + osp 17.0 and rhel 9.2 (and onwards) and osp 17.1
There was a problem hiding this comment.
If it's only a RHEL 9.0 issue, I suggest that we don't add this code, to reduce complexity.
I think dev-install is going to support 16.2 and OSP 17.1 in the longterm, we can't add support for every version of OSP, especially the unsupported ones (17.0).
|
rhel 9.0 on OSP17.0 is not something we'll support, we'll wait for 17.1 GA and see how things go. |
|
|
||
| For OSP 16.2, the recommended OS is RHEL 8.4. For OSP 17, the recommended RHEL will be 9. | ||
| For OSP 16.2, the recommended OS is RHEL 8.4. For OSP 17.0, the required RHEL will be 9.0. |
There was a problem hiding this comment.
17.1 being out soon, I would prefer that we document this one since it's the one that will be supported in long term.
Please change it to 17.1 and 9.2.
| # when the rhcs5 portion of the build is started. | ||
| # | ||
| # Therefore it is easier to use the config.json method for podman. | ||
| - name: Setup Docker registry authentication |
There was a problem hiding this comment.
I'm currently investigating this too. Not saying I reject your solution here but I'm looking if we can do easier.
| @@ -41,10 +41,12 @@ | |||
| ansible.builtin.shell: | | |||
| dnf module disable -y container-tools:rhel8 | |||
| dnf module enable -y container-tools:"{{ rhsm_container_tools_version }}" | |||
| when: ansible_distribution_major_version | int < 9 | |||
There was a problem hiding this comment.
yes we need this change for sure.
| - name: Install virt module # noqa no-changed-when | ||
| ansible.builtin.shell: | | ||
| dnf module disable -y virt:rhel | ||
| dnf module enable -y virt:"{{ virt_release }}" | ||
| when: ansible_distribution_major_version | int < 9 |
There was a problem hiding this comment.
here too we need this change.
|
@gprocunier finally back to it (17.1 is now GA 🥳), I've proposed #216 Let me know what you think, testing will follow soon when time permits. |
|
@gprocunier I'll close that PR if you don't mind, since we have PR#216 which address the OSP 17.1 use case. |
Updated support for doing rhsm_enabled builds against official RHEL9/RHOS with registry.redhat.io
Added fixes for using service accounts via the terms based registry on access.redhat.com
Misc fixes for deploying virtually in libvirt/kvm
Provided an example local-overrides for rhos17 on rhel9 with details on creating the required components.