a11y.useValidAnchor を有効にする

shiguredo · Nov 17, 2023 · 5830c16 · 5830c16
1 parent 2aa9222
commit 5830c16
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/biome.json b/biome.json
@@ -11,7 +11,6 @@
         "useExhaustiveDependencies": "off"
       },
       "a11y": {
-        "useValidAnchor": "off",
         "useAnchorContent": "off"
       }
     }

diff --git a/src/components/DebugPane/Message.tsx b/src/components/DebugPane/Message.tsx
@@ -50,7 +50,8 @@ export const Message: React.FC<Props> = (props) => {
   return (
     <div className="border border-light rounded mb-1 bg-dark" data-title={title}>
       <div className="d-flex justify-content-between align-items-center text-break">
-        <a
+        <button
+          type="button"
           className={`debug-title ${disabled ? 'disabled' : ''}`}
           onClick={() => setShow(!show)}
           aria-controls={ariaControls}
@@ -62,7 +63,7 @@ export const Message: React.FC<Props> = (props) => {
           ) : null}
           {label}
           <span>{title}</span>
-        </a>
+        </button>
         <div className="border-left">
           <CopyLogButton
             text={

diff --git a/src/components/DevtoolsPane/index.tsx b/src/components/DevtoolsPane/index.tsx
@@ -211,9 +211,9 @@ const RowSignalingOptions: React.FC = () => {
   return (
     <Row className="form-row">
       <Col>
-        <a href="#" className={linkClassNames.join(' ')} onClick={onClick}>
+        <button type="button" className={linkClassNames.join(' ')} onClick={onClick}>
           Signaling options
-        </a>
+        </button>
       </Col>
       <Collapse in={!collapsed}>
         <div>
@@ -261,9 +261,9 @@ const RowAdvancedSignalingOptions: React.FC = () => {
   return (
     <Row className="form-row">
       <Col>
-        <a href="#" className={linkClassNames.join(' ')} onClick={onClick}>
+        <button type="button" className={linkClassNames.join(' ')} onClick={onClick}>
           Advanced signaling options
-        </a>
+        </button>
       </Col>
       <Collapse in={!collapsed}>
         <div>
@@ -341,9 +341,9 @@ const RowMediaOptions: React.FC = () => {
   return (
     <Row className="form-row">
       <Col>
-        <a href="#" className={linkClassNames.join(' ')} onClick={onClick}>
+        <button type="button" className={linkClassNames.join(' ')} onClick={onClick}>
           Media options
-        </a>
+        </button>
       </Col>
       <Collapse in={!collapsed}>
         <div>

diff --git a/src/components/Header/DownloadReportButton.tsx b/src/components/Header/DownloadReportButton.tsx
@@ -118,7 +118,7 @@ export const DownloadReportButton: React.FC = () => {
         defaultValue="Download report"
         onClick={onClick}
       />
-      <a ref={anchorRef} style={{ display: 'none' }} />
+      <button type="button" ref={anchorRef} style={{ display: 'none' }} />
     </>
   )
 }