useExhaustiveDependencies を有効にする

shiguredo · Nov 22, 2023 · c373798 · c373798
1 parent 0f838b9
commit c373798
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/biome.json b/biome.json
@@ -7,9 +7,6 @@
     "enabled": true,
     "rules": {
       "all": true,
-      "correctness": {
-        "useExhaustiveDependencies": "off"
-      },
       "style": {
         "useNamingConvention": "off"
       },

diff --git a/src/components/AlertMessages.tsx b/src/components/AlertMessages.tsx
@@ -14,7 +14,7 @@ const Reconnect: React.FC = () => {
   }
   useEffect(() => {
     dispatch(reconnectSora())
-  }, [])
+  }, [dispatch])
   return (
     <Toast delay={20000} onClose={onClose}>
       <Toast.Header className={'bg-warning text-white'}>

diff --git a/src/components/Video/Video.tsx b/src/components/Video/Video.tsx
@@ -15,6 +15,7 @@ const VideoElement: React.FC<VideoProps> = (props) => {
   const { displayResolution, stream, mute, audioOutput, setHeight } = props
   const videoRef = useRef<CustomHTMLVideoElement>(null)
   const videoSize = getVideoSizeByResolution(displayResolution)
+
   useEffect(() => {
     const resizeObserver = new ResizeObserver((entries: ResizeObserverEntry[]) => {
       entries.filter((entry) => {
@@ -30,7 +31,7 @@ const VideoElement: React.FC<VideoProps> = (props) => {
     return () => {
       resizeObserver.disconnect()
     }
-  }, [])
+  }, [setHeight, audioOutput, stream])
 
   useEffect(() => {
     if (videoRef.current && mute) {
@@ -63,7 +64,7 @@ const VideoElement: React.FC<VideoProps> = (props) => {
     } else if (videoRef.current && stream === null) {
       videoRef.current.srcObject = null
     }
-  }, [stream])
+  }, [stream, audioOutput])
 
   if (audioOutput && videoRef.current?.setSinkId && stream && stream.getAudioTracks().length > 0) {
     videoRef.current.setSinkId(audioOutput)

diff --git a/src/pages/devtools.tsx b/src/pages/devtools.tsx
@@ -19,7 +19,7 @@ const Devtools: React.FC = () => {
     return () => {
       dispatch(disconnectSora())
     }
-  }, [])
+  }, [dispatch])
   return (
     <>
       <MediacaptureRegionTarget />