biome-ignore で逃げる

shiguredo · Nov 17, 2023 · d96624f · d96624f
1 parent 6fee2bf
commit d96624f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 10 deletions.
diff --git a/biome.json b/biome.json
@@ -6,10 +6,7 @@
   "linter": {
     "enabled": true,
     "rules": {
-      "recommended": true,
-      "correctness": {
-        "useExhaustiveDependencies": "off"
-      }
+      "recommended": true
     }
   },
   "formatter": {

diff --git a/src/components/AlertMessages.tsx b/src/components/AlertMessages.tsx
@@ -12,9 +12,9 @@ const Reconnect: React.FC = () => {
   const onClose = (): void => {
     dispatch(setSoraReconnecting(false))
   }
+  // biome-ignore lint/correctness/useExhaustiveDependencies: <explanation>
   useEffect(() => {
     dispatch(reconnectSora())
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [])
   return (
     <Toast delay={20000} onClose={onClose}>

diff --git a/src/components/Video/Video.tsx b/src/components/Video/Video.tsx
@@ -15,7 +15,8 @@ const VideoElement: React.FC<VideoProps> = (props) => {
   const { displayResolution, stream, mute, audioOutput, setHeight } = props
   const videoRef = useRef<CustomHTMLVideoElement>(null)
   const videoSize = getVideoSizeByResolution(displayResolution)
-  useEffect(() => {
+  // biome-ignore lint/correctness/useExhaustiveDependencies: <explanation>
+useEffect(() => {
     const resizeObserver = new ResizeObserver((entries: ResizeObserverEntry[]) => {
       entries.filter((entry) => {
         setHeight(entry.contentRect.height)
@@ -30,7 +31,6 @@ const VideoElement: React.FC<VideoProps> = (props) => {
     return () => {
       resizeObserver.disconnect()
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [])
 
   useEffect(() => {
@@ -39,7 +39,8 @@ const VideoElement: React.FC<VideoProps> = (props) => {
     }
   }, [mute])
 
-  useEffect(() => {
+  // biome-ignore lint/correctness/useExhaustiveDependencies: <explanation>
+useEffect(() => {
     if (videoRef.current && stream) {
       // Chrome で first video frame まで音声が出力されない現象のワークアラウンド
       // 一旦 video tracks を disabled にしておき、 loadedmetadata イベントで有効にする
@@ -64,7 +65,6 @@ const VideoElement: React.FC<VideoProps> = (props) => {
     } else if (videoRef.current && stream === null) {
       videoRef.current.srcObject = null
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [stream])
 
   if (audioOutput && videoRef.current?.setSinkId && stream && stream.getAudioTracks().length > 0) {

diff --git a/src/pages/devtools.tsx b/src/pages/devtools.tsx
@@ -12,14 +12,14 @@ import { MediacaptureRegionTarget } from '@/components/MediacaptureRegionTarget'
 
 const Devtools: React.FC = () => {
   const dispatch = useAppDispatch()
+  // biome-ignore lint/correctness/useExhaustiveDependencies: <explanation>
   useEffect(() => {
     dispatch(setInitialParameter())
     dispatch(setMediaDevices())
     dispatch(initLyra())
     return () => {
       dispatch(disconnectSora())
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [])
   return (
     <>