デバイス無効化時の Track の停止漏れを修正する #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
05c847e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1248b338.sora-devtools.pages.dev |
| Branch Preview URL: | https://feature-stop-media-processor.sora-devtools.pages.dev |
voluntas
reviewed
Oct 23, 2023
| @@ -1697,15 +1643,12 @@ export const setMicDevice = (micDevice: boolean) => { | |||
| } | |||
| } else if (state.soraContents.sora && state.soraContents.localMediaStream) { | |||
| // Sora 接続中の場合 | |||
| stopLocalAudioTrack(dispatch, state); | |||
voluntas
approved these changes
Oct 23, 2023
|
動作確認済みです。 |
…ture/stop-media-processor-on-device-disabled
|
細々とブラウザ依存対応などを入れてしまったので、お手数ですが動作確認してもらえると助かります 🙏 |
|
Chrome / Safari で動作確認済み。Safari はちょっとよくわからない挙動がありましたが、後回しで。 |
|
マージします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更履歴
request mediaconnectを実行した後に、Enable mic deviceEnable video deviceのトグルでデバイスを無効化した時に Media Processor が保持している Track の停止漏れを修正する