Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: offer で取得したセッション ID を表示できるようにする #488

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

tnamao
Copy link
Contributor

@tnamao tnamao commented Dec 7, 2023

変更履歴

  • [ADD] Sora 接続後にセッション ID の表示を追加する
    • Sora 2023.2.0 以降は sora-js-sdk が type: offer から取得したセッション ID を表示に使用する
    • それ以外の場合は notify の connection.created イベントで取得したセッション ID を表示に使用する
    • @tnamao

@torikizi torikizi self-requested a review December 7, 2023 09:19
Copy link
Contributor

@torikizi torikizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございました。
動作確認しました。問題なさそうです。

@tnamao
Copy link
Contributor Author

tnamao commented Dec 7, 2023

マージします

@tnamao tnamao merged commit a6f7e43 into develop Dec 7, 2023
4 checks passed
@tnamao tnamao deleted the feature/type-offer-session-id branch December 7, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants