Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gDM に Audio の MediaConstraints を渡せるようにする #502

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

tnamao
Copy link
Contributor

@tnamao tnamao commented Jan 17, 2024

変更履歴

  • [CHANGE] getDisplayMedia 使用時の MediaConstraints に audio も含めるようにする
    • gDM に渡す MediaConstraint の audio パラメータは audio のトグルの状態や Media options の設定と連動している
    • @tnamao

Copy link

cloudflare-workers-and-pages bot commented Jan 17, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6977b97
Status: ✅  Deploy successful!
Preview URL: https://9562fe89.sora-devtools.pages.dev
Branch Preview URL: https://feature-gdm-with-audio.sora-devtools.pages.dev

View logs

@tnamao tnamao changed the title [WIP] gDM に Audio の MediaConstraints を渡せるようにする gDM に Audio の MediaConstraints を渡せるようにする Jan 17, 2024
@tnamao tnamao requested a review from voluntas January 17, 2024 10:12
@tnamao
Copy link
Contributor Author

tnamao commented Jan 17, 2024

マージします

@tnamao tnamao merged commit 355b8f5 into develop Jan 17, 2024
2 checks passed
@tnamao tnamao deleted the feature/gdm-with-audio branch January 17, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants