-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devtools の LYRA サポートを削除する #518
Conversation
copilot summary This pull request involves significant changes to the codebase, primarily focused on removing the LYRA audio codec settings. The changes include the deletion of the LYRA codec settings from various files, removal of related code and files, and the updating of documentation to reflect these changes. Removal of LYRA audio codec settings:
Deletion of related code and files:
Updates to documentation and other files:
|
// lyra-wasm は SharedArrayBuffer を使っているので、それを有効にするために必要な | ||
// HTTP 応答ヘッダの設定を行うサービスワーカを登録する。 | ||
if ('serviceWorker' in navigator) { | ||
navigator.serviceWorker.register('./service-worker.js').then((registration) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
実害はないと思うので、単なる自分用のメモコメントですが、このコードを消してもすでに登録済みのサービスワーカーは(ブラウザのキャッシュを削除するまで)残り続けそうですね。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
良さそうに見えました
Deploying with Cloudflare Pages
|
sora-js-sdk を 2024.1.0-canary.0 の Lyra 削除バージョンに入れ替えました |
sora-js-sdk の対応するバージョンがリリースされて (package.json の依存を更新して) からマージ可能です
変更履歴
LYRA
の設定を削除するservice-worker.js
の削除