Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devtools の LYRA サポートを削除する #518

Merged
merged 7 commits into from
Mar 7, 2024
Merged

Conversation

tnamao
Copy link
Contributor

@tnamao tnamao commented Mar 6, 2024

sora-js-sdk の対応するバージョンがリリースされて (package.json の依存を更新して) からマージ可能です

変更履歴

  • [CHANGE] オーディオコーデック LYRA の設定を削除する
    • 関連するコードと service-worker.js の削除
    • next.config.js から不要な設定の削除
    • @tnamao

@tnamao tnamao requested review from voluntas and sile March 6, 2024 08:45
@sile
Copy link
Member

sile commented Mar 7, 2024

copilot summary


This pull request involves significant changes to the codebase, primarily focused on removing the LYRA audio codec settings. The changes include the deletion of the LYRA codec settings from various files, removal of related code and files, and the updating of documentation to reflect these changes.

Removal of LYRA audio codec settings:

  • CHANGES.md: Removed the LYRA audio codec settings and associated code, including service-worker.js. Also removed unnecessary settings from next.config.js.
  • DOCUMENT.md: Removed the audioLyraParamsBitrate section which dealt with the LYRA codec bitrate settings.
  • instructions.json: Removed the audioLyraParamsBitrate section from the instructions.

Deletion of related code and files:

Updates to documentation and other files:

  • src/app/slice.ts: Removed the audioLyraParamsBitrate from the initial state and the slice. [1] [2]
  • src/constants.ts: Removed LYRA from the AUDIO_CODEC_TYPES and deleted AUDIO_LYRA_PARAMS_BITRATES. [1] [2]
  • src/types.ts: Removed audioLyraParamsBitrate from the SoraDevtoolsState and ConnectionOptionsState types. [1] [2]
  • src/utils.ts: Removed the parsing and creation of audioLyraParamsBitrate from the query string and connect options respectively. [1] [2]

// lyra-wasm は SharedArrayBuffer を使っているので、それを有効にするために必要な
// HTTP 応答ヘッダの設定を行うサービスワーカを登録する。
if ('serviceWorker' in navigator) {
navigator.serviceWorker.register('./service-worker.js').then((registration) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

実害はないと思うので、単なる自分用のメモコメントですが、このコードを消してもすでに登録済みのサービスワーカーは(ブラウザのキャッシュを削除するまで)残り続けそうですね。

Copy link
Member

@sile sile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうに見えました

Copy link

cloudflare-workers-and-pages bot commented Mar 7, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c530841
Status: ✅  Deploy successful!
Preview URL: https://ad8ae145.sora-devtools.pages.dev
Branch Preview URL: https://feature-remove-lyra.sora-devtools.pages.dev

View logs

@tnamao tnamao changed the title [DO NOT MERGE] devtools の LYRA サポートを削除する devtools の LYRA サポートを削除する Mar 7, 2024
@tnamao
Copy link
Contributor Author

tnamao commented Mar 7, 2024

sora-js-sdk を 2024.1.0-canary.0 の Lyra 削除バージョンに入れ替えました
マージ可能になったのでマージします

@tnamao tnamao merged commit b86eb18 into develop Mar 7, 2024
4 checks passed
@tnamao tnamao deleted the feature/remove-lyra branch March 7, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants