Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

各 ID の表示を notify で自身の connection.created を受け取ったタイミングに変更する #526

Merged
merged 5 commits into from
Mar 19, 2024

Conversation

tnamao
Copy link
Contributor

@tnamao tnamao commented Mar 18, 2024

変更履歴

  • [CHANGE] Session ID と自身の Connection ID Client ID の表示を type: notifyconnection.created を受け取ったタイミングでの表示に変更する
    • この変更に伴い、Sora Devtools の Sora 接続状態の確認は state の soraContents.connectionStatus の値の確認も追加する
    • @tnamao

This pull request involves changes in the src/app/actions.ts, src/app/slice.ts, src/components/DebugPane/SendDataChannelMessagingMessage.tsx, src/components/DevtoolsPane/CameraDeviceForm.tsx, src/components/DevtoolsPane/MicDeviceForm.tsx, and src/components/Header/index.tsx files. The changes focus on modifying the conditions for setting the sora, connectionStatus, connectionId, clientId, and sessionId states. It also updates the conditions for sending messages and enabling or disabling the camera and microphone devices.

Changes in src/app/actions.ts:

  • The setSoraCallbacks function now checks if the connection_id received matches the current connectionId before setting the sessionId, connectionId, and clientId states.
  • The setSoraCallbacks function now sets the sessionId, connectionId, and clientId states to null when sora is set to null.
  • The connectSora function now sets the sora state before connecting to sora to ensure it can be referenced when the connection.created notify is received. [1] [2]
  • The connectSora, reconnectSora, disconnectSora, setMicDevice, and setCameraDevice functions now check the connectionStatus before performing their respective operations. [1] [2] [3] [4] [5] [6] [7] [8]

Changes in src/app/slice.ts:

  • The setSora action now only sets the connectionId, clientId, and sessionId states to null when sora is set to null.

Changes in src/components/DebugPane/SendDataChannelMessagingMessage.tsx, src/components/DevtoolsPane/CameraDeviceForm.tsx, src/components/DevtoolsPane/MicDeviceForm.tsx, and src/components/Header/index.tsx:

  • The components now check the connectionStatus before performing their respective operations. [1] [2] [3] [4] [5]

Changes in CHANGES.md:

  • The changes in the Session ID, Connection ID, and Client ID display and the removal of the LYRA audio codec configuration were documented.

@tnamao tnamao requested a review from voluntas March 18, 2024 09:20
Copy link

Deploying sora-devtools with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8e731f4
Status: ✅  Deploy successful!
Preview URL: https://81944e8f.sora-devtools.pages.dev
Branch Preview URL: https://feature-display-id-by-notify.sora-devtools.pages.dev

View logs

@tnamao tnamao requested a review from a team March 18, 2024 09:36
Copy link
Contributor

@miosakuma miosakuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

以下のケースでエラーなく動作することを確認しました。
Mac Chrome で recvonly, sendonly, sendrecv, simulcast の動作を確認しています。

  • デフォルト設定
  • signaling_notify_connection_id = false
  • signaling_notify = false

@torikizi
Copy link
Contributor

以下のバリエーションで確認しました。
正常に動いていることを確認できました。

  • macOS
    • Chrome
      • multistream sendonly / sendrecv / recvonly
      • Spotlight sendrecv
      • Simulcast sendrecv
    • Safari
      • multistream sendrecv
      • Spotlight sendrecv
      • Simulcast sendrecv
    • Edge
      • multistream sendrecv
      • Spotlight sendrecv
      • Simulcast sendrecv
        -Firefox
      • multistream sendrecv
      • Spotlight sendrecv
  • Android
    • multistream sendrecv
    • Spotlight sendrecv
    • Simulcast sendrecv
  • iOS
    • multistream sendrecv
    • Spotlight sendrecv
    • Simulcast sendrecv

@voluntas
Copy link
Member

@tnamao PR 出すときは下に自動生成追加するようにしてくださいませ 🙏

@voluntas voluntas merged commit fdf01e0 into develop Mar 19, 2024
2 checks passed
@voluntas voluntas deleted the feature/display-id-by-notify branch March 19, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants