-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
各 ID の表示を notify で自身の connection.created を受け取ったタイミングに変更する #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying sora-devtools with Cloudflare Pages
|
miosakuma
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
以下のケースでエラーなく動作することを確認しました。
Mac Chrome で recvonly, sendonly, sendrecv, simulcast の動作を確認しています。
- デフォルト設定
signaling_notify_connection_id = false
signaling_notify = false
以下のバリエーションで確認しました。
|
torikizi
approved these changes
Mar 19, 2024
@tnamao PR 出すときは下に自動生成追加するようにしてくださいませ 🙏 |
voluntas
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更履歴
Session ID
と自身のConnection ID
Client ID
の表示をtype: notify
のconnection.created
を受け取ったタイミングでの表示に変更するsoraContents.connectionStatus
の値の確認も追加するThis pull request involves changes in the
src/app/actions.ts
,src/app/slice.ts
,src/components/DebugPane/SendDataChannelMessagingMessage.tsx
,src/components/DevtoolsPane/CameraDeviceForm.tsx
,src/components/DevtoolsPane/MicDeviceForm.tsx
, andsrc/components/Header/index.tsx
files. The changes focus on modifying the conditions for setting thesora
,connectionStatus
,connectionId
,clientId
, andsessionId
states. It also updates the conditions for sending messages and enabling or disabling the camera and microphone devices.Changes in
src/app/actions.ts
:setSoraCallbacks
function now checks if theconnection_id
received matches the currentconnectionId
before setting thesessionId
,connectionId
, andclientId
states.setSoraCallbacks
function now sets thesessionId
,connectionId
, andclientId
states to null whensora
is set to null.connectSora
function now sets thesora
state before connecting tosora
to ensure it can be referenced when theconnection.created
notify is received. [1] [2]connectSora
,reconnectSora
,disconnectSora
,setMicDevice
, andsetCameraDevice
functions now check theconnectionStatus
before performing their respective operations. [1] [2] [3] [4] [5] [6] [7] [8]Changes in
src/app/slice.ts
:setSora
action now only sets theconnectionId
,clientId
, andsessionId
states to null whensora
is set to null.Changes in
src/components/DebugPane/SendDataChannelMessagingMessage.tsx
,src/components/DevtoolsPane/CameraDeviceForm.tsx
,src/components/DevtoolsPane/MicDeviceForm.tsx
, andsrc/components/Header/index.tsx
:connectionStatus
before performing their respective operations. [1] [2] [3] [4] [5]Changes in
CHANGES.md
:Session ID
,Connection ID
, andClient ID
display and the removal of theLYRA
audio codec configuration were documented.