Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mediaType に mp4Media を追加する #593

Merged
merged 25 commits into from
Oct 23, 2024
Merged

Conversation

sile
Copy link
Member

@sile sile commented Oct 23, 2024

以下のように mp4Media を追加して、MP4 ファイルから配信を行えるようにしました。
将来的には、ローカルファイルからだけでなく URL で MP4 ファイルを指定できるようにするかもしれません。

image

This pull request introduces support for handling MP4 media streams, along with several updates to dependencies and configurations. The key changes include adding a new media type, updating relevant files to support this new feature, and modifying dependencies to include the necessary libraries.

New Feature: MP4 Media Stream Support

  • CHANGES.md: Added mp4Media to mediaType for handling H.264 + Opus MP4 files, initially supported on Chrome and Edge. ([CHANGES.mdR14-R17](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-d975bf659606195d2165918f93e1cf680ef68ea3c9cab994f033705fea8238b2R14-R17))
  • instructions.json: Added description for mp4File to specify the MP4 file to be used when mp4Media is selected. ([instructions.jsonR98-R100](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-d4a451ad2863e5577b7cc521ab817f447f4a7c53c11bf6281e7fc34511f35f2aR98-R100))
  • src/app/actions.ts: Updated createMediaStreamPickedState to include mp4MediaStream and added logic to handle mp4Media type. ([[1]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-f614e3891e365664ae453d152ad62d608f4f5fa9708ead03b11241130e00af00L462-R462), [[2]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-f614e3891e365664ae453d152ad62d608f4f5fa9708ead03b11241130e00af00R483), [[3]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-f614e3891e365664ae453d152ad62d608f4f5fa9708ead03b11241130e00af00L495-R496), [[4]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-f614e3891e365664ae453d152ad62d608f4f5fa9708ead03b11241130e00af00R674-R678), [[5]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-f614e3891e365664ae453d152ad62d608f4f5fa9708ead03b11241130e00af00R1688), [[6]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-f614e3891e365664ae453d152ad62d608f4f5fa9708ead03b11241130e00af00R1785), [[7]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-f614e3891e365664ae453d152ad62d608f4f5fa9708ead03b11241130e00af00R1999))
  • src/app/slice.ts: Added mp4MediaStream to the initial state and created a new action setMp4MediaStream. ([[1]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-45bfbe03821b84e4fcd3d64b38e126de5d7b7a7a7537adf8a7088fb9c9c6194eR3), [[2]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-45bfbe03821b84e4fcd3d64b38e126de5d7b7a7a7537adf8a7088fb9c9c6194eR96), [[3]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-45bfbe03821b84e4fcd3d64b38e126de5d7b7a7a7537adf8a7088fb9c9c6194eR292-R294))
  • src/app/store.ts: Included setMp4MediaStream in the list of serializable actions and paths ignored by the Redux store. ([src/app/store.tsR20-R27](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-efbc9c2c3c62a72fb9d047216d1c0ed4a8223e51ce11cbcbb30a7a0a6049d042R20-R27))

Dependency Updates

  • package.json: Added @shiguredo/mp4-media-stream dependency. ([package.jsonR30](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R30))
  • pnpm-lock.yaml: Updated to include the new @shiguredo/mp4-media-stream package and reverted several other dependencies to previous versions for compatibility. ([[1]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR17-R19), [[2]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR681-R683), [[3]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL794-R801), [[4]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL807-R814), [[5]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL912-R919), [[6]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL1088-R1095), [[7]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL1280-R1287), [[8]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL1295-R1305), [[9]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL1467-R1473), [[10]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL1502-R1508), [[11]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL1548-R1554), [[12]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR1915-R1916), [[13]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL2056-R2077), [[14]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL2109-R2117), [[15]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL2162-R2170), [[16]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL2321-R2329), [[17]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL2355-R2363), [[18]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL2368-R2382), [[19]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL2575-R2601), [[20]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL2617-R2629), [[21]](https://github.com/shiguredo/sora-devtools/pull/593/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL2668-R2676))

@sile sile requested review from voluntas and tnamao October 23, 2024 05:43
Copy link

cloudflare-workers-and-pages bot commented Oct 23, 2024

Deploying sora-devtools with  Cloudflare Pages  Cloudflare Pages

Latest commit: 22775e2
Status:🚫  Build failed.

View logs

@voluntas
Copy link
Member

動作確認できました。 +1 です。

@sile sile merged commit bf6b8b0 into develop Oct 23, 2024
5 of 6 checks passed
@sile sile deleted the feature/mp4-media-stream branch October 23, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants