Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve types #567

Merged
merged 9 commits into from
Oct 2, 2024
Merged

Feature/improve types #567

merged 9 commits into from
Oct 2, 2024

Conversation

voluntas
Copy link
Member

@voluntas voluntas commented Oct 2, 2024

This pull request introduces significant changes to the signaling message handling in the ConnectionBase class by replacing hardcoded strings with constants. Additionally, it includes updates to the import statements and type definitions to support these changes.

Refactoring for Signaling Messages:

Constants and Types:

  • packages/sdk/src/constants.ts: Added constants for signaling message types and roles, such as SIGNALING_MESSAGE_TYPE_OFFER, SIGNALING_ROLE_SENDRECV, and others. This centralizes the definitions and makes the code more readable and easier to update.

  • packages/sdk/src/types.ts: Updated type definitions to use the newly introduced constants, ensuring type safety and consistency across the codebase. [1] [2] [3]

Import Statements:

  • packages/sdk/src/base.ts: Updated import statements to include the newly defined constants and types, ensuring that all necessary dependencies are correctly imported. [1] [2]

These changes collectively improve the maintainability, readability, and consistency of the codebase by centralizing the definitions of signaling message types and roles.

@voluntas voluntas merged commit bba0957 into develop Oct 2, 2024
7 checks passed
@voluntas voluntas deleted the feature/improve-types branch October 2, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant