[WIP] signalingmessage callback を追加する #568
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the signaling message handling in the Sora SDK. The key changes include adding a new event type for signaling messages, updating related imports and method calls, and ensuring proper logging and event creation for signaling messages.
Enhancements to signaling message handling:
examples/sendonly/main.mts
: AddedSignalingMessageEvent
type to imports, boundsignalingmessage
event toonsignalingmessage
method, and implemented theonsignalingmessage
method to log signaling messages. [1] [2] [3]packages/sdk/src/base.ts
: AddedSIGNALING_MESSAGE_TYPE_CONNECT
to imports, replacedcreateSignalingMessage
withcreateConnectSignalingMessage
, and addedsignalingmessage
callback to handle signaling message events. [1] [2] [3] [4] [5]Updates to type definitions and utilities:
packages/sdk/src/types.ts
: Addedsignalingmessage
callback toCallbacks
type and updatedSignalingMessageEvent
interface to includetransportType
. [1] [2]packages/sdk/src/utils.ts
: AddedcreateSignalingMessageEvent
utility function and updated imports to include new types and functions. [1] [2]Minor import adjustments:
packages/sdk/src/sora.ts
: AddedSignalingMessageEvent
to imports and exports. [1] [2]