Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] signalingmessage callback を追加する #568

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

voluntas
Copy link
Member

@voluntas voluntas commented Oct 2, 2024

This pull request introduces enhancements to the signaling message handling in the Sora SDK. The key changes include adding a new event type for signaling messages, updating related imports and method calls, and ensuring proper logging and event creation for signaling messages.

Enhancements to signaling message handling:

  • examples/sendonly/main.mts: Added SignalingMessageEvent type to imports, bound signalingmessage event to onsignalingmessage method, and implemented the onsignalingmessage method to log signaling messages. [1] [2] [3]

  • packages/sdk/src/base.ts: Added SIGNALING_MESSAGE_TYPE_CONNECT to imports, replaced createSignalingMessage with createConnectSignalingMessage, and added signalingmessage callback to handle signaling message events. [1] [2] [3] [4] [5]

Updates to type definitions and utilities:

Minor import adjustments:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant