npm に登録している latest のバージョンを E2E テストで検証する仕組みを追加する #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the CI/CD workflows and some updates to the examples and tests. The most important changes include re-enabling multiple Node.js versions in the e2e-test workflow, adding a new npm package e2e-test workflow, displaying the SDK version in the examples, and modifying the Vite configuration for e2e tests.
CI/CD Workflow Updates:
.github/workflows/e2e-test.yml: Re-enabled multiple Node.js versions (18, 20, 22) in the matrix strategy..github/workflows/npm-pkg-e2e-test.yml: Added a new workflow to run npm package e2e tests with multiple SDK versions and Node.js versions. This workflow includes steps for checking out the code, setting up Node.js, installing dependencies, and running Playwright tests. It also includes Slack notifications for success and failure.Examples Updates:
examples/messaging/main.mts: Added aconsole.logstatement to log thechannelIdPrefix.examples/sendonly/index.html: Added an element to display the SDK version.examples/sendonly/main.mts: Added code to display the SDK version in the#sdk-versionelement.Tests Updates:
tests/sendonly_recvonly.spec.ts: Added steps to verify and log the SDK version in the sendonly and recvonly pages.Configuration Updates:
vite.config.mjs: Modified the alias configuration to be disabled when theNPM_PKG_E2E_TESTenvironment variable is set totrue. This allows multiple versions of thesora-js-sdkto be installed and tested.