Gtk3: Changed selected backdrop fg/bg colors to shades of grey. #303
Conversation
Before: "blue on grey" was unreadable. Issue: shimmerproject#300 Deleted several specific styles in favor of one general style.
| @@ -60,7 +60,8 @@ $backdrop_text_color: mix($text_color, $backdrop_base_color, 80%); | |||
| $backdrop_bg_color: $bg_color; | |||
| $backdrop_fg_color: mix($fg_color, $backdrop_bg_color, 50%); | |||
| $backdrop_insensitive_color: if($variant == 'light', darken($backdrop_bg_color, 15%), lighten($backdrop_bg_color, 15%)); | |||
| $backdrop_selected_fg_color: if($variant == 'light', $backdrop_base_color, $backdrop_text_color); | |||
| $backdrop_selected_fg_color: if($variant == 'light', darken($base_color, 50%), $backdrop_text_color); | |||
| $backdrop_selected_bg_color: if($variant == 'light', darken($base_color, 17%), lighten($bg_color, 17%)); | |||
There was a problem hiding this comment.
Name of variable backdrop_selected_bg_color should be written in all lowercase letters with hyphens instead of underscores
Name of variable base_color should be written in all lowercase letters with hyphens instead of underscores
Name of variable bg_color should be written in all lowercase letters with hyphens instead of underscores
| @@ -60,7 +60,8 @@ $backdrop_text_color: mix($text_color, $backdrop_base_color, 80%); | |||
| $backdrop_bg_color: $bg_color; | |||
| $backdrop_fg_color: mix($fg_color, $backdrop_bg_color, 50%); | |||
| $backdrop_insensitive_color: if($variant == 'light', darken($backdrop_bg_color, 15%), lighten($backdrop_bg_color, 15%)); | |||
| $backdrop_selected_fg_color: if($variant == 'light', $backdrop_base_color, $backdrop_text_color); | |||
| $backdrop_selected_fg_color: if($variant == 'light', darken($base_color, 50%), $backdrop_text_color); | |||
There was a problem hiding this comment.
Name of variable backdrop_selected_fg_color should be written in all lowercase letters with hyphens instead of underscores
Name of variable backdrop_text_color should be written in all lowercase letters with hyphens instead of underscores
Name of variable base_color should be written in all lowercase letters with hyphens instead of underscores
| @@ -4517,6 +4512,7 @@ headerbar.selection-mode button.titlebutton, | |||
|
|
|||
| &:backdrop { | |||
| color: $backdrop_selected_fg_color; | |||
| background-color: $backdrop_selected_bg_color; | |||
There was a problem hiding this comment.
Name of variable backdrop_selected_bg_color should be written in all lowercase letters with hyphens instead of underscores
|
|
||
| &:backdrop { | ||
| color: $backdrop_selected_fg_color; | ||
| background-color: $backdrop_selected_bg_color; |
There was a problem hiding this comment.
Name of variable backdrop_selected_bg_color should be written in all lowercase letters with hyphens instead of underscores
| } | ||
|
|
||
| &:backdrop { | ||
| color: $backdrop_selected_fg_color; |
There was a problem hiding this comment.
Name of variable backdrop_selected_fg_color should be written in all lowercase letters with hyphens instead of underscores
Properties should be ordered background-color, color
| background-color: $selected_bg_color; | ||
| } | ||
|
|
||
| &:backdrop { |
There was a problem hiding this comment.
Begin pseudo elements with double colons: ::
| // don't differentiate between focussed and unfocussed widgets. | ||
| &:focus, &{ | ||
| color: $selected_fg_color; | ||
| background-color: $selected_bg_color; |
There was a problem hiding this comment.
Name of variable selected_bg_color should be written in all lowercase letters with hyphens instead of underscores
|
|
||
| // don't differentiate between focussed and unfocussed widgets. | ||
| &:focus, &{ | ||
| color: $selected_fg_color; |
There was a problem hiding this comment.
Name of variable selected_fg_color should be written in all lowercase letters with hyphens instead of underscores
Properties should be ordered background-color, color
| background-color: $selected_bg_color; | ||
|
|
||
| // don't differentiate between focussed and unfocussed widgets. | ||
| &:focus, &{ |
There was a problem hiding this comment.
Each selector in a comma sequence should be on its own single line
Opening curly brace { should be preceded by one space
|
Here's an example:
I tested mainly through gtk3-widget-factory. |
Before: "grey on blue" was unreadable.
Related Issue: #300
Implementation Detail: Deleted several specific styles in favor of one general style.