Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move notification app icon to categories #418

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

newhoa
Copy link
Contributor

@newhoa newhoa commented Jan 9, 2024

The new notification icon was accepted upstream, with some icon tweaks. This update adds those tweaks and renames and moves the icon to categories, matching upstream.

The new notification icon was accepted upstream, with some icon tweaks.
This update adds those tweaks and renames and moves the icon to categories,
matching upstream.
@ochosi
Copy link
Member

ochosi commented Jan 30, 2024

@newhoa Sorry, I've been lagging behind so far on reviews :( I really don't want to block you on this - I've invited you to the repo as a collaborator, so you should be able to merge without my ack.

@newhoa newhoa enabled auto-merge (squash) February 8, 2024 10:40
@newhoa newhoa disabled auto-merge February 8, 2024 10:41
@newhoa
Copy link
Contributor Author

newhoa commented Feb 8, 2024

@ochosi it will not let me merge without a review, and it will not let me review/approve my own PR. When I click on Review it is disabled with the message:

Pull request authors can’t approve their own pull request

Thanks for the invite and sorry if I'm not understanding things correctly. (Oh, also when merging do you select Squash or Rebase when there is only one commit?)

@ochosi
Copy link
Member

ochosi commented Feb 9, 2024

I always go for rebase.

You can change the settings for what's required for being able to merge a PR, so that reviews are not. That's how I did things when I was working on this mostly on my own.

@ochosi
Copy link
Member

ochosi commented Feb 9, 2024

I have adjusted those settings so you should be good to go.

@newhoa newhoa merged commit 0badd3f into shimmerproject:master Feb 9, 2024
1 check passed
@newhoa newhoa deleted the categories-notifications branch March 11, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants