Use native fs #13
Open
Use native fs #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsPath has a known vulnerability and had no updates from a long time. This PR will revert the dependency added to fix recursive writes while updating the call with the native functions. Note that this requires a node version > 11.5 where these asynchronous functions where introduced. Set as >=12 to use the LTS versions.
I don't think this breaks backward compatibility but does require a newer version of node.
LC43
added a commit
to LC43/gulp-version-number
that referenced
this pull request
Jan 20, 2020
gulp is used as dev dependency to run the tests. I had no issues running the tests with the newest version, using the latest gulp-cli version and node. This removes the remaining vulnerabilities from this package. See shinate#13.
Open
neonsunlight
approved these changes
Apr 17, 2020
There was a problem hiding this comment.
Hello! @shinate please merge this PR, if you can. Thank you in advance!
|
Hi @shinate , can you please merge this PR? Thanks you in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fsPath has a known vulnerability and had no updates from a long time. This PR will revert the dependency added to fix recursive writes while updating the call with the native functions.
Note that this requires a node version > 11.5 where these asynchronous functions where introduced. Set as >=12 to use the LTS versions.
I don't think this breaks backward compatibility but does require a newer version of node.
Testing
I ran the existing tests and it worked. I didn't expect the image to have a different md5, but there wasn't actually a image to start.
On my own tests, it was successful in creating recursively many directories and replacing the target.