Skip to content

Commit

Permalink
Fix registration
Browse files Browse the repository at this point in the history
  • Loading branch information
aritchie committed May 16, 2024
1 parent 24d98d9 commit 38e8151
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 44 deletions.
10 changes: 0 additions & 10 deletions src/Shiny.Extensions.WebHosting/Contracts/Address.cs

This file was deleted.

13 changes: 0 additions & 13 deletions src/Shiny.Extensions.WebHosting/Contracts/ContactMethod.cs

This file was deleted.

4 changes: 0 additions & 4 deletions src/Shiny.Extensions.WebHosting/Contracts/Geo.cs

This file was deleted.

6 changes: 0 additions & 6 deletions src/Shiny.Extensions.WebHosting/Contracts/Name.cs

This file was deleted.

5 changes: 0 additions & 5 deletions src/Shiny.Extensions.WebHosting/Contracts/Ranges.cs

This file was deleted.

8 changes: 4 additions & 4 deletions src/Shiny.Extensions.WebHosting/RegistrationExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ public static WebApplicationBuilder AddInfrastructureForAppDomain(this WebApplic
})
.ToArray();

return builder.AddInfrastructure(assemblies);
return builder.AddInfrastructureWithAssemblies(assemblies);
}


public static WebApplicationBuilder AddInfrastructure(this WebApplicationBuilder builder, params Assembly[] assemblies)
public static WebApplicationBuilder AddInfrastructureWithAssemblies(this WebApplicationBuilder builder, params Assembly[] assemblies)
{
if (assemblies.Length == 0)
throw new InvalidOperationException("No assemblies passed to scan");
Expand All @@ -54,15 +54,15 @@ public static WebApplicationBuilder AddInfrastructure(this WebApplicationBuilder
{
Console.WriteLine("Registering Infrastructure Module: " + moduleType.FullName);
var module = (IInfrastructureModule)Activator.CreateInstance(moduleType)!;
builder.AddInfrastructure(module);
builder.AddInfrastructureWithModules(module);
Console.WriteLine("Successfully Registered Infrastructure Module: " + moduleType.FullName);
}
}
return builder;
}


public static WebApplicationBuilder AddInfrastructure(this WebApplicationBuilder builder, params IInfrastructureModule[] modules)
public static WebApplicationBuilder AddInfrastructureWithModules(this WebApplicationBuilder builder, params IInfrastructureModule[] modules)
{
foreach (var module in modules)
{
Expand Down
4 changes: 2 additions & 2 deletions tests/Shiny.Extensions.WebHosting.Tests/RegistrationTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public void DidRegisterAll_AppDomain()
public void DidRegisterAll_SingleAssembly()
{
var builder = WebApplication.CreateBuilder();
builder.AddInfrastructure(Assembly.GetExecutingAssembly());
builder.AddInfrastructureWithAssemblies(Assembly.GetExecutingAssembly());
this.FireAll(builder);
}

Expand All @@ -36,7 +36,7 @@ public void DidRegisterAll_SingleAssembly()
public void DidRegister_OnlyOneModule()
{
var builder = WebApplication.CreateBuilder();
builder.AddInfrastructure(new Module1());
builder.AddInfrastructureWithModules(new Module1());

Module1.AddCalled.Should().BeTrue("Module1.Add should be true");
Module1.UseCalled.Should().BeFalse("Module1.Use should not have been fired");
Expand Down

0 comments on commit 38e8151

Please sign in to comment.