Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyright headers / Add verification for generated code pieces / Update to Go 1.20 / Update Shipwright dependency #61

Conversation

SaschaSchwarze0
Copy link
Member

Changes

Did a quick cleanup on various things. Sorry for not separating commits or even PRs.

Fixes #8

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

The controller is now built with Go 1.20

@SaschaSchwarze0 SaschaSchwarze0 added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Aug 8, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2023
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-updates-copyright branch 4 times, most recently from 83fbe46 to fc82482 Compare August 8, 2023 20:05
Add verification for generated code pieces
Update to Go 1.20
Update Shipwright dependency
@SaschaSchwarze0 SaschaSchwarze0 removed the request for review from sbose78 August 8, 2023 20:14
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee, SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SaschaSchwarze0,qu1queee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 72fa28b into shipwright-io:main Aug 14, 2023
3 checks passed
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-updates-copyright branch November 24, 2023 14:58
@SaschaSchwarze0 SaschaSchwarze0 mentioned this pull request Feb 12, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Ensure Copyright Headers
3 participants