Set empty string as escape character for CSVs to avoid deprecation warnings in PHP 8.4 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnings in PHP 8.4
acelaya
changed the title
acelaya
force-pushed
the
feature/csv-escape
branch
from
9a7a93f
to
7c01f8c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=========================================
Coverage 95.36% 95.37%
Complexity 163 163
=========================================
Files 38 38
Lines 604 605 +1
=========================================
+ Hits 576 577 +1
Misses 28 28 ☔ View full report in Codecov by Sentry. |
|
To verify this did fix something, I run a CI without the workaround. In there, all tests for
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See thephpleague/csv#532