Added ./dist/translations directory to exports to allow dynamic importing of directory contents #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting of directory contents
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This seems fine to me. @KonnorRogers feel free to merge unless you have concerns. |
|
Just to get ahead of this, I added the other directories to the exportmaps. Thank you for the PR! |
…o fixTranslationDynamicImport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #2208, currently you cannot dynamically import the contents of the ./dist/translations/ directory as bundlers such as Webpack refuse to import the entire directory's contents and will only allow individual explicit files to be imported because of the ./dist/translations/* export rule. Therefore this PR adds an additional export rule to allow the entire directory to be imported to resolve this issue.
Feel free to let me know if this is TOTALLY not the correct way to resolve this.
Proposal to fix #2208