Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(carousel): navigation arrow directionality for ltr/rtl #2230

Closed
wants to merge 1 commit into from

Conversation

alenaksu
Copy link
Collaborator

@alenaksu alenaksu commented Oct 25, 2024

This PR resolves an issue where the carousel navigation arrows were displayed incorrectly for LTR and RTL directionality

Before After
before after

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
shoelace ✅ Ready (Inspect) Visit Preview Oct 25, 2024 8:53am

@patrick-mcdougle
Copy link

Thanks for being proactive to fix this. This is no longer needed since #2235 was merged.

@claviska
Copy link
Member

Whoops. Thanks @alenaksu, didn't see this PR before I noticed the bug on my own.

Cheers!

@claviska claviska closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants