fix possibly leaking eventlisteners #2253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
evayde
force-pushed
the
fix/drawer-dialog-possible-leaking-eventlisteners
branch
from
ec111ce
to
440bd68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DialogandDrawerdo not clean up the keyboard event listener indisconnectedCallback. This might lead to an issue in SPAs when linking away from within anopenedDialog or Drawer. The issue only exists for Browsers that don't support the CloseWatcher API.In this case, there's even a function called
removeOpenListenerswhich can be called ondisconnectedCallback. This already solves the whole issue.