SG-30084 Custom revert of 3e72b44a to fix the SSLEOFError #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-lang
force-pushed
the
ticket/SG-34910-fixup-by-reverting-3e72b44a
branch
from
acb688c
to
5c44bcd
Compare
julien-lang
changed the base branch from
master
to
ticket/SG-34910-fixup-ssl-eol-exception
julien-lang
commented
Jun 5, 2024
| @@ -112,6 +112,8 @@ def _is_mimetypes_broken(): | |||
| have a self-signed internal certificate that isn't included in our certificate bundle, you may | |||
| not require the added security provided by enforcing this. | |||
| """ | |||
| if os.environ.get("SHOTGUN_DISABLE_SSL_VALIDATION", False): | |||
| NO_SSL_VALIDATION = True | |||
There was a problem hiding this comment.
Do we really want to bring this variable back?
julien-lang
force-pushed
the
ticket/SG-34910-fixup-by-reverting-3e72b44a
branch
from
5c44bcd
to
b477fbb
Compare
julien-lang
force-pushed
the
ticket/SG-34910-fixup-ssl-eol-exception
branch
from
e626ed4
to
f9f50d3
Compare
julien-lang
changed the title
Base automatically changed from
ticket/SG-34910-fixup-ssl-eol-exception
to
master
June 7, 2024 19:52
Could not "git revert" because the files have changed too much
julien-lang
force-pushed
the
ticket/SG-34910-fixup-by-reverting-3e72b44a
branch
from
b477fbb
to
5ca2da7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could not "git revert" because the files have changed too much
All this code in 3e72b44 was created to support Python versions 2.5 and below (the Python SSL module was added in Python 2.6: https://docs.python.org/2.7/library/ssl.html)
Since we don't support these versions of Python anymore and this creates a problem with SSLEOFError, let's just revert it all.