Ticket/28441 hide template projects by default #79
Conversation
|
Questions: why is the test-suite so insanely slow locally? The Travis test passed much faster. Is it something to do w/ us hitting our puny VM? Does |
shotgun_api3/shotgun.py
Outdated
|
|
||
| def _version_str(version): | ||
| """Converts a tuple of int's to a '.' separated str""" | ||
| return '.'.join(map(str, version)) |
There was a problem hiding this comment.
Can't believe that Python's join is called on the separator... It should be a functionality of an enumerable, not a string... Weird...!
|
Ran the entire suite on 5.4, then 6.0, then 6.0-28441, just to make sure all was coming out green. But took aaaaaaages 😆 |
|
Note: see shotgunsoftware/shotgun#1119 for CRUD changes. |
nemoDreamer
force-pushed
the
ticket/28441_hide_template_projects_by_default
branch
3 times, most recently
from
9477d11
to
4157455
Compare
|
CRUD does not currently seem to handle the new flag correctly when coming from an API call, so tests are failing "correctly". We're putting this on the back-burner, since at least like this, we're not breaking existing API functionality (running the old API agains a new site comes up green). |
nemoDreamer
force-pushed
the
ticket/28441_hide_template_projects_by_default
branch
from
4157455
to
dbb23e9
Compare
shotgun_api3/shotgun.py
Outdated
| if not self.version or self.version < (2, 4, 0): | ||
| raise ShotgunError("JSON API requires server version 2.4 or "\ | ||
| "higher, server is %s" % (self.version,)) | ||
| :param feature: dict supported version and human label { 'version': (int, int, int), 'label': str } |
There was a problem hiding this comment.
Please update the documentation.
nemoDreamer
force-pushed
the
ticket/28441_hide_template_projects_by_default
branch
from
dbb23e9
to
6a74c73
Compare
|
@nemoDreamer can this be closed? |
|
No idea, @manneohrstrom : it's 3 years old, and I have no idea if it's still wanted. |
We're adding
Project.is_templatein v6.0.0 to support multiple template projects. Unlikeinclude_archived_projects(which defaults toTrue), the newinclude_template_projectsCRUD flag defaults toFalse.ensure_include_archived_projectsinclude_archived_flagsupport w/ the logic reversedtest_api.py