Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformstudios patch fix shotgun descriptor incorrect system name behaviour #721

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Oct 14, 2019

  1. Merge pull request #2 from shotgunsoftware/master

    Update fork to latest official master
    reformstudios authored Oct 14, 2019
    Configuration menu
    Copy the full SHA
    52534aa View commit details
    Browse the repository at this point in the history
  2. Adds "system_name" field to "shotgun" descriptor.

    Adding a "system_name" field to the "shotgun" descriptor allows for overriding the default behaviour in the "get_system_name" method which returns the wrong name for use in hook templates where the {engine} tag is used. 
    eg, if a descriptor points to a toolkit bundle names "tk-houdini_release_v1.2.3", and a hook path is of the form "path: /some/path/to/{engine}/hook" then the {engine} field will be replaced by {entity_type}_{entity_id}, which will not point to the expected location of, for example, 'tl-houdini/hook' it will instead point to 'customNonProjectEntity01_104/hook'.
    Adding an optional field to allow the user to set the "system_name" manually allows the default behaviour to be overridden where required without breaking existing expected behaviour.
    This should resolve the issues raised on the community site on pages :- 
    - https://community.shotgunsoftware.com/t/possible-hook-path-bug/3365
    - https://community.shotgunsoftware.com/t/names-for-apps-frameworks-specified-via-shotgun-descriptors/2989
    reformstudios authored Oct 14, 2019
    Configuration menu
    Copy the full SHA
    39edeb4 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Merge branch 'master' into reformstudios-patch-fix-shotgun-descriptor…

    …-incorrect-system-name-behaviour
    reformstudios authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    07d048e View commit details
    Browse the repository at this point in the history
  2. lint

    reformstudios authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    eacb388 View commit details
    Browse the repository at this point in the history