Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temp git clones clutter issue. #845

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BoubQC
Copy link

@BoubQC BoubQC commented Mar 23, 2022

Use filesystem.safe_delete_folder instead of shutil.rmtree since the later doesn't delete read-only files.

Use filesystem.safe_delete_folder instead of shutil.rmtree since the later didn't delete read-only files.
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #845 (e74fe51) into master (4f3880b) will decrease coverage by 6.55%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
- Coverage   79.38%   72.82%   -6.56%     
==========================================
  Files         177      177              
  Lines       19302    19302              
==========================================
- Hits        15322    14056    -1266     
- Misses       3980     5246    +1266     
Impacted Files Coverage Δ
python/tank/descriptor/io_descriptor/git.py 86.17% <100.00%> (ø)
python/tank/commands/app_info.py 17.24% <0.00%> (-79.32%) ⬇️
python/tank/bootstrap/import_handler.py 18.18% <0.00%> (-73.74%) ⬇️
python/tank/commands/folders.py 20.00% <0.00%> (-69.10%) ⬇️
python/tank/commands/setup_project.py 17.32% <0.00%> (-66.29%) ⬇️
python/tank/commands/cache_yaml.py 31.57% <0.00%> (-52.64%) ⬇️
python/tank/commands/util.py 37.50% <0.00%> (-37.50%) ⬇️
python/tank/commands/core_localize.py 39.40% <0.00%> (-36.44%) ⬇️
python/tank/commands/unregister_folders.py 12.58% <0.00%> (-36.43%) ⬇️
python/tank/commands/tank_command.py 47.34% <0.00%> (-32.98%) ⬇️
... and 43 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@staceyoue staceyoue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants