Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SG-33499 Remove orphan resources after removal of Qt4 #985

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

julien-lang
Copy link
Contributor

Remove Qt4-related things we missed in #973

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.87%. Comparing base (7c52d07) to head (d3d420e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
- Coverage   79.90%   79.87%   -0.03%     
==========================================
  Files         198      198              
  Lines       20719    20719              
==========================================
- Hits        16555    16550       -5     
- Misses       4164     4169       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@carlos-villavicencio-adsk carlos-villavicencio-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julien-lang julien-lang changed the title SG-30560 Remove orphan resources after removal of Qt4 SG-33499 Remove orphan resources after removal of Qt4 Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants