-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SG-36129 Add customized sort fields #96
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I would also like to have better error handling for the case you pointed out. Is it possible to invest more time for it?
Also, I think the documentation should be updated as well. Probably this page.
info.yml
Outdated
description: "Controls what fields appear for sorting | ||
" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: "Controls what fields appear for sorting | |
" | |
description: "Controls what fields appear for sorting" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I had intended to add more details there, that was just place holder. I'll update that thanks
Also I wonder if the setting name should not be my tasks specific and then you list the tab under it. That way if we add the sort field to other tabs we wont need to change the setting name. |
actions_list[3].setChecked(True) | ||
actions_list[4].setChecked(False) | ||
actions_list[0].setChecked(True) | ||
actions_list[1].setChecked(False) | ||
elif sort_order == "desc": | ||
actions_list[4].setChecked(True) | ||
actions_list[3].setChecked(False) | ||
actions_list[0].setChecked(False) | ||
actions_list[1].setChecked(True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved the sort order to the top, it was shown at the bottom of the list. This brings it inline with the web UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for that @pscadding
This comment was marked as outdated.
This comment was marked as outdated.
We decided not to implement the changes on the SG Utils for better catching. We didn't want to introduce unnecessary risk for the handling of this edge case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Makes the My Tasks tab sort fields configurable through the yml settings.
The user can choose any fields including linked fields to sort by, assuming that they are valid fields to sort by.
The default sort options are the same as before + the step which appeared to be mostly added by possibly accidentally excluded. (Note the UI styling looks a little weird here, because I'm running out of my terminal and not a DCC)
The user can then customise the list through the env config.
If its configured with a non existing field it will result in an error in the console if the user picks that sort field in the list.
I'm not sure there is a better way of handling this as it asynchronous so I can't just wrap the instruction to load data in a try except.
I think in order to get a better handle on it we might need to make changed to the shotgun model.
An example of the error you would get is here: