Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create own vpc+subnet to ensure success when the user has no default VPC #21

Closed
wants to merge 1 commit into from

Conversation

rukai
Copy link
Member

@rukai rukai commented Oct 19, 2023

Turns out we dont actually need this (at least yet) and it adds a whole bunch of complexity and slows down startup/shutdown significantly.
So I'm going to abandon this as a draft PR for now in case we need it later on.

The functionality works, but there are still 2 tasks to go:

  • fully parallelize startup and cleanup
  • allow cleanup to run in less runs, currently we need to run cleanup three times to fully eliminate the vpc. We should be able to get it down to 2 times.

@rukai
Copy link
Member Author

rukai commented Oct 25, 2023

Superceded by #22

@rukai rukai closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant