support connecting via VPNs/bastion instances #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
use_private_addresses
branch
from
0ba1765
to
a11b1c2
Compare
rukai
force-pushed
the
use_private_addresses
branch
2 times, most recently
from
d6d304f
to
d20e5ef
Compare
rukai
force-pushed
the
use_private_addresses
branch
from
d20e5ef
to
cfc18f8
Compare
rukai
changed the title
rukai
changed the title
conorbros
approved these changes
Oct 23, 2023
cjrolo
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #23
Currently aws-throwaway will connect to instances over the internet via the instances public ip address.
This is very convenient as it means the user does not have to setup any kind of VPN or bastion instance.
However being able to connect to a private ip via a VPN or bastion instance is very useful and even required in many environments.
To support both of these use cases, this PR introduces a config setting that decides whether to connect to instances private or public ip address.
This PR:
Awsstruct to be created by a builder struct:AwsBuilderuse_public_addressesmethod to theAwsBuilderstructI also changed aws-throwaway/examples/aws-throwaway-test.rs so that it doesnt leave files around making it more suitable for testing the project.