Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-sdk [breaking change] #33

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

rukai
Copy link
Member

@rukai rukai commented Nov 13, 2023

The latest aws sdk release was able to replace Option<T> with just a T in many cases where it was always Some(_).

This is a breaking change as we include a type from aws-sdk-ec2 in our public API.

@rukai rukai changed the title Update aws-sdk Update aws-sdk [breaking change] Nov 13, 2023
@rukai rukai requested a review from conorbros November 13, 2023 05:42
@rukai rukai mentioned this pull request Nov 16, 2023
@rukai rukai force-pushed the update-aws-dep branch 2 times, most recently from 1aff9b9 to bd5a84f Compare November 16, 2023 20:56
@rukai
Copy link
Member Author

rukai commented Nov 16, 2023

Added the rust-version bump to this PR.

@rukai rukai force-pushed the update-aws-dep branch 3 times, most recently from e38f18e to 9560f4b Compare November 21, 2023 04:18
@rukai rukai merged commit 7b1fd0d into shotover:main Nov 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants