Various bugfixes #46
Merged
Various bugfixes #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
+ Sendchange is a fix for a bug introduced by #43It actually broke our public interface by changing the type of the future that is created by the async method
create_security_groupas well as its caller and its caller and its caller...Finally resulting in this very weird error in the users application if they expect the future to be Sync. (which we do)
The rest are bugs introduced by #41 from poor testing on my part.
They can be reproduced by running the aws-throwaway-test-multiple-instances.rs example which I originally neglected to do.