Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI backend: fix user-data #51

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

rukai
Copy link
Member

@rukai rukai commented Mar 10, 2024

The user-data field is kind of cursed and will accept plaintext or base64 encoded plaintext which it automatically detects somehow.

However sometimes this automatic detection does not occur and the user-data remains as undecoded base64 and I cannot find any specification of what the base64 format needs to look like for it to automatically decode it.

So, to avoid this issue I am just directly passing in the user-data without base64 encoding.
And come to think of it, its just simpler all around if we dont have to encode as base64.

@rukai rukai requested a review from conorbros March 10, 2024 23:46
@conorbros conorbros merged commit 87dc1d2 into shotover:main Mar 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants