New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks for running on our system #57

Merged

rukai merged 2 commits into shotover:main from rukai:tweaks

Jul 22, 2024

Member

rukai commented Jul 19, 2024

In order to run within a new internal system we need to make two changes to aws-throwaway:

The AZ needs to be configurable, it is not suitable to run within us-east-1c in our system since it does not have a default subnet.
EBS must be encrypted in our internal system. This can just be set globally without a config since for the use cases aws-throwaway is targeting whether or not encryption is enabled does not matter.

Additionally the error message is improved in the case where the selected AZ has no default subnet.


          Tweaks for running on our system

12e82bb

justinweng-instaclustr approved these changes

View reviewed changes

ronycsdu approved these changes

View reviewed changes


          Merge branch 'main' into tweaks

7467e94

rukai enabled auto-merge (squash)

July 22, 2024 00:59

rukai merged commit 37134f5 into shotover:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet