update site to latest shotover docs #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for infallible-bartik-4f03f3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rukai
force-pushed
the
v0.4.1
branch
5 times, most recently
from
bd04dd7
to
d98afe0
Compare
rukai
changed the title
ronycsdu
approved these changes
Sep 12, 2024
justinweng-instaclustr
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in changes to docs since the website was last updated.
Rather than using the latest master we use
--branchto specify a certain tag, this way we can avoid pulling in unpublished changes from the latest master.However 0.4.1 is actually broken so for now we just comment it out and use the latest main branch.
The additional sed line is adding another case to a super hacky workaround for the fact that we are using an old alpha release of this web framework that blows up when we use certain markdown codeblock language names and upgrading the framework is non-trivial.
In this case its blowing up because of this line specifically: https://github.com/shotover/shotover-proxy/blob/e94328d979121f00a336820af1cfeaa65d3e34b2/docs/src/dev-docs/debugging.md?plain=1#L41
I think merging this PR should publish the changes to the site.