Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag to use system libdeflate #659

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

shssoichiro
Copy link
Owner

This need was raised in https://bugs.gentoo.org/944285. Can be enabled with --features system-libdeflate to use the libdeflate located on the user's system instead of building our own.

Copy link
Collaborator

@AlexTMjugador AlexTMjugador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, allowing users to choose which libraries Oxipng links to is a welcome concept. Thanks!

As a side note, the underlying Gentoo packaging issue shouldn't occur with Oxipng 9.1.3. This version updates libdeflater to 1.22, and according to the related PR, the problem stemmed from the older libdeflate version.

@AlexTMjugador AlexTMjugador merged commit 4df1464 into master Dec 3, 2024
14 checks passed
@AlexTMjugador AlexTMjugador deleted the allow-system-libdeflate branch December 3, 2024 19:03
@AlexTMjugador
Copy link
Collaborator

cc @lo48576 in case the information above about internal libdeflater updates on Oxipng 9.1.3 is useful in some way for Gentoo packaging.

@lo48576
Copy link

lo48576 commented Dec 6, 2024

Thank you for introducing the flag!

I'm aware of updated libdeflater dependency in the latest version. I'll use a patch for v9.1.3 and system-libdeflate flag for the later versions (because it is (maybe) more preferred way in Gentoo Linux).

The Gentoo repo has libdeflate package (app-arch/libdeflate) but currently the last version added is 1.21, and oxipng 9.1.3 depends on libdeflater 1.22.0, so I'll wait for =app-arch/deflate-1.22 to be added to the Gentoo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants