Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support of search #16

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

biggydbs
Copy link

@biggydbs biggydbs commented Oct 4, 2017

No description provided.

@shubhodeep9 shubhodeep9 self-requested a review October 4, 2017 20:31
Copy link
Owner

@shubhodeep9 shubhodeep9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't understand what you did here, please explain what you are trying to solve.

@biggydbs
Copy link
Author

biggydbs commented Oct 4, 2017

if you are searching pipsearch pygame... no result will come... but you want some result to come related to pygame, if I am not wrong, so I splitted the "term" (input) and then search for each string in input and appending the result in packages.

@shubhodeep9
Copy link
Owner

@biggydbs I think you didn't understand the problem statement.
In simple, the issue #14 states the need for a command link application that can be triggered via
$ pipsearch
and giving arguments as
$ pipsearch pygame
So it will find PyPi for "pygame" which actually returns many values.

@biggydbs
Copy link
Author

biggydbs commented Oct 4, 2017

Okay got it.

@biggydbs
Copy link
Author

biggydbs commented Oct 4, 2017

Its working from command Line using " pipsearch --term pygame "
Here are some links which will help you push your modules in pypi :

https://kushaldas.in/posts/building-command-line-tools-in-python-with-click.html
http://click.pocoo.org/5/setuptools/#setuptools-integration

1 - You need to register to pypi to put your module there.
2 - Create a file .pypirc and put all your username and passwords there
3 - After that run :
python setup.py sdist upload -r pypi .
pip install --editable .

This I added for testing.
https://pypi.python.org/pypi/pipsearch

@shubhodeep9
Copy link
Owner

  1. I can't seem to make it work.
  2. I don't understand why you changes the directory structure just to create a binary. You simple could have mentioned endpoints in setup.py, and used argparse to manipulate arguments.
  3. Don't create repositories in PyPi just for testing, for the projects that are authored by someone else. That is an unfair practice.

@biggydbs
Copy link
Author

biggydbs commented Oct 5, 2017

I will delete it, it was just for testing to make it work.As soon as testing is done, I will remove it.

Using click I tested, if you want me to change it to argparse I can do that.

@shubhodeep9
Copy link
Owner

shubhodeep9 commented Oct 5, 2017

@biggydbs Uploading to PyPi is for later. First construct a setup.py that installs it on our system.
For reference: check my repo that has command line interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants