feat: nfsd support as module package #713
Conversation
TMaYaD
force-pushed
the
main
branch
2 times, most recently
from
7c946a2
to
eca94ce
Compare
| @@ -0,0 +1,9 @@ | |||
| CONFIG_NFSD=m | |||
There was a problem hiding this comment.
should we simply build nfsd as a module as part of the main kernel build @frezbo ?
There was a problem hiding this comment.
I think we update the the Kconfig and only build the modules that we ship by default in talos, then these extra can be build as separate modules shipped as extensions, so we don't increase initramfs size
There was a problem hiding this comment.
That's the same approach as I'm taking here. Right?
LMK if there is anything else needed to get this approved and merged in.
There was a problem hiding this comment.
That's the same approach as I'm taking here. Right?
meant adding to the actual kernel config under kernel/build/config-<arch>, I'll try to experiment and see if that approach works for our use case. Might take a while
There was a problem hiding this comment.
I couldn't currently figure out where kernel is being used to build installer. If you can point me, I'll be more than happy to run a few experiments of my own.
There was a problem hiding this comment.
https://github.com/siderolabs/talos/blob/main/Dockerfile#L77-L99 you can update this with your kernel image and do make installer PUSH=true
There was a problem hiding this comment.
quick question: does this work without rpc service running?
There was a problem hiding this comment.
@TMaYaD does this require rpc service? Else I can fix this up and get this merged.
There was a problem hiding this comment.
I worked on this a while back and don't remember how I got this working. I'll check and get back to you.
Build nfsd support as module package. This allows to build an nfsd
extension to be used with projects like openebs/dynamic-nfs-provisioner.
Talos can load it via machine-config:
```yaml
machine:
# Configures the kernel.
kernel:
# Kernel modules to load.
modules:
- name: nfsd # Module name.
```
Signed-off-by: Subhash Chandra <[email protected]>
|
any chance to get this pushed? |
|
With 1.8 having a lot of focus on improving volume management, this might be a great thing to try to get in. |
Build nfsd support as module package. This allows to build an nfsd extension to be used with projects like openebs/dynamic-nfs-provisioner.
Talos can load it via machine-config: