Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate away from blue-build #75

Merged
merged 19 commits into from
Sep 15, 2024
Merged

Conversation

HerrNaN
Copy link
Collaborator

@HerrNaN HerrNaN commented Aug 17, 2024

This PR removes the dependency on blue-build/github-action and takes ownership of the build process. The changes include:

  • Migrate the contents of recipe.yaml to a Containerfile
  • Replace blue-build/github-action with base steps
  • Cleanup unused remnants of blue-build

@HerrNaN
Copy link
Collaborator Author

HerrNaN commented Sep 12, 2024

image

@HerrNaN
Copy link
Collaborator Author

HerrNaN commented Sep 14, 2024

image
IT WORKS!!! 🎉

@HerrNaN HerrNaN changed the title feat: take over ownership of building from blue-build feat: migrate away from blue-build Sep 15, 2024
@HerrNaN HerrNaN changed the title feat: migrate away from blue-build chore: migrate away from blue-build Sep 15, 2024
Copy link
Member

@williamleven williamleven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So freaking neat!

Comment on lines +7 to +8
branches:
- main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, branch builds will only be triggered on PRs, leaving push on for all branches causes double workflow triggers (pull_request and push) for pullrequests which is annoying

@HerrNaN HerrNaN merged commit ce1b610 into main Sep 15, 2024
1 check passed
@HerrNaN HerrNaN deleted the feat/simple-containerfile branch September 15, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move away from out-sourced build instructions to local Containerfile builds
2 participants