report unsupported macros by katex and expand user-define commands #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renee-k
changed the title
siefkenj
reviewed
May 29, 2024
packages/unified-latex-to-pretext/libs/report-and-expand-macros.ts
Outdated
Show resolved
Hide resolved
packages/unified-latex-to-pretext/libs/report-and-expand-macros.ts
Outdated
Show resolved
Hide resolved
packages/unified-latex-to-pretext/libs/report-and-expand-macros.ts
Outdated
Show resolved
Hide resolved
packages/unified-latex-to-pretext/libs/report-and-expand-macros.ts
Outdated
Show resolved
Hide resolved
packages/unified-latex-to-pretext/tests/unified-latex-macro.test.ts
Outdated
Show resolved
Hide resolved
packages/unified-latex-to-pretext/tests/unified-latex-macro.test.ts
Outdated
Show resolved
Hide resolved
packages/unified-latex-to-pretext/tests/unified-latex-macro.test.ts
Outdated
Show resolved
Hide resolved
siefkenj
reviewed
Jun 5, 2024
packages/unified-latex-to-pretext/tests/report-unsupported-macro-katex.test.ts
Outdated
Show resolved
Hide resolved
packages/unified-latex-to-pretext/tests/report-unsupported-macro-katex.test.ts
Outdated
Show resolved
Hide resolved
packages/unified-latex-to-pretext/tests/report-unsupported-macro-katex.test.ts
Show resolved
Hide resolved
packages/unified-latex-to-pretext/libs/expand-user-defined-macros.ts
Outdated
Show resolved
Hide resolved
packages/unified-latex-to-pretext/libs/expand-user-defined-macros.ts
Outdated
Show resolved
Hide resolved
packages/unified-latex-to-pretext/libs/expand-user-defined-macros.ts
Outdated
Show resolved
Hide resolved
packages/unified-latex-to-pretext/libs/expand-user-defined-macros.ts
Outdated
Show resolved
Hide resolved
packages/unified-latex-to-pretext/libs/expand-user-defined-macros.ts
Outdated
Show resolved
Hide resolved
packages/unified-latex-to-pretext/libs/expand-user-defined-macros.ts
Outdated
Show resolved
Hide resolved
renee-k
changed the title
Bo-Y-G
reviewed
Jun 11, 2024
There was a problem hiding this comment.
The code visits all the nodes and returns a list of macros' content which are not supported by katex in math mode.
There was a problem hiding this comment.
For the unsupported macro which is being pushed to the list, is it just the name of the macro or as well as its parameters?
Bo-Y-G
reviewed
Jun 11, 2024
There was a problem hiding this comment.
The code returns macros that is newly defined by the user and expands them. macroInfo collects the information of the anything that is of new commends, which is implmented as part of the "../uified-latex-util-macros". is Object.fromEntries used to integrate everything into a string? The needToExpand function visits all the nodes and checks if it has nodes and if the content match, why is that?
siefkenj
reviewed
Jun 12, 2024
packages/unified-latex-to-pretext/libs/pre-conversion-subs/report-unsupported-macro-katex.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reportMacrosUnsupportedByKatex function will return a list of all macros in math mode that aren't supported by Katex within the AST passed in as input. The ExpandUserDefinedMacros function will expand user-defined commands such as from
\newcommand,\renewcommand, etc., modifying the AST passed in as input.