Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_playlist: fix title for podcast episodes (#622) #623

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

czifumasa
Copy link
Collaborator

Quick fix for get_playlist method. Some playlist items had None as a title. (#622)

After refactor in (#612), title is resolved using watchEndpoint. Podcast episodes do not have one. They have browseEndpoint with pageType = MUSIC_PAGE_TYPE_NON_MUSIC_AUDIO_TRACK_PAGE instead.

@sigma67
Copy link
Owner

sigma67 commented Jul 15, 2024

Hi @czifumasa thanks for your persistence here.

On the weekend I also played around with get_playlist and found that for suggestions only, the author is not parsed correctly using your approach. Maybe you can have a look if you have time.

@sigma67 sigma67 merged commit c39bb32 into sigma67:main Jul 15, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants