get_playlist: fix artists for unnoficial videos (#627) #630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #627.
In the scope of this PR the new logic has been removed for albums. So for albums
flexColumns
are hardcoded and for playlist they are still resolved usingnavigationEndpoints
. There are border cases with columns withoutnavigationEndpoint
, where I have to guess their meaning. Those cases are different for albums and for playlists, so I cannot use the same logic for both methods. Albums always have the same order offlexColumns
, so dynamic resolving is not needed there.Now it's safe to assume that first column without
navigationEndpoint
is an artist column.Additionally I added some tests for
get_playlist
. I prepared json for collaborative playlist with all types of tracks that has been problematic in the recent days:Asserts will check if all those tracks have title and artist and if there is album for regular songs. I added the same asserts for already existing tests with mocked jsons in
get_playlist
andget_album
.