Report sync of block import via blob import #5836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mergify queue |
realbigsean
added
ready-for-merge
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 7fda18b |
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fix lookup stuck incident reported in
Sync should be notified when a block abandons the da_checker to continue its child lookups. Block import can be completed both via block gossip import and blob import.
I am not 100% sure this fix is strictly necessary, but it's a good to have that can unstuck lookups if the logic to de-duplicate blob requests fails.
Proposed Changes
Emit
GossipBlockProcessResultalso from blob import if the block gets imported