-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust: make cargo build slightly more debuggable #227
Conversation
Signed-off-by: William Woodruff <[email protected]>
To summarize:
To fix all of that, we would have had to check all of the |
Signed-off-by: Andrew Pan <[email protected]>
91da056
to
7eecf40
Compare
Signed-off-by: Andrew Pan <[email protected]>
LGTM, thanks @tnytown! |
@@ -0,0 +1,11 @@ | |||
[package] | |||
name = "sigstore-protobuf-specs-codegen" | |||
version = "0.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(whoops comment didnt post) Does this version need to be in sync with the protobuf-specs version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's okay for us to bump this version separately, similar to what we're doing with the derive
crate -- at any rate, this shouldn't ever be published :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this is purely an internal, helper-only crate (it performs the codegen for the actual crate, which will remain in sync with the protobuf-specs version).
Handing this PR off to @tnytown, who will switch us back to AOT generation, once again completing the cycle of pain.