Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to run verification tests locally #99

Closed
steiza opened this issue Sep 20, 2023 · 1 comment
Closed

Make it easier to run verification tests locally #99

steiza opened this issue Sep 20, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@steiza
Copy link
Member

steiza commented Sep 20, 2023

Description

The existing instructions to run the tests locally involve using a GitHub token to get an OIDC JWT from https://github.com/sigstore-conformance/extremely-dangerous-public-oidc-beacon.

If you're only testing verification use-cases though, you don't need an OIDC JWT.

We should make it so if you run pytest test --skip-signing ... you don't need a GitHub token, since you don't need an OIDC JWT.

@steiza steiza added the enhancement New feature or request label Sep 20, 2023
steiza added a commit to steiza/sigstore-conformance that referenced this issue Sep 20, 2023
For sigstore#99

If you're only testing verification use-cases locally, you don't need
the OIDC JWT.

Signed-off-by: Zach Steindler <[email protected]>
@woodruffw
Copy link
Member

woodruffw commented Sep 21, 2023

Fully agreed! I saw you opened #100; thank you!

woodruffw pushed a commit that referenced this issue Sep 21, 2023
* Make it easier to run verification test locally

For #99

If you're only testing verification use-cases locally, you don't need
the OIDC JWT.

Signed-off-by: Zach Steindler <[email protected]>

* Nicer error message for not providing arguments

```
sigstore-conformance$ pytest test --entrypoint /Users/steiza/code/steiza/sigstore-conformance/sigstore-python-conformance
Please specify one of '--github-token' or '--skip-signing'
sigstore-conformance$ echo $?
3
```

Signed-off-by: Zach Steindler <[email protected]>

---------

Signed-off-by: Zach Steindler <[email protected]>
@steiza steiza closed this as completed Sep 26, 2023
@jku jku mentioned this issue Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants