Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to run verification test locally #100

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

steiza
Copy link
Member

@steiza steiza commented Sep 20, 2023

For #99

Summary

If you're only testing verification use-cases locally, you don't need the OIDC JWT.

You can test this change with:

(env) $ pytest test --skip-signing --entrypoint=SIGSTORE_CLIENT

Release Note

  • Enabled easier local testing for verification with pytest test --skip-signing --entrypoint=SIGSTORE_CLIENT

Documentation

N/A

For sigstore#99

If you're only testing verification use-cases locally, you don't need
the OIDC JWT.

Signed-off-by: Zach Steindler <[email protected]>
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, one design thought!

```
sigstore-conformance$ pytest test --entrypoint /Users/steiza/code/steiza/sigstore-conformance/sigstore-python-conformance
Please specify one of '--github-token' or '--skip-signing'
sigstore-conformance$ echo $?
3
```

Signed-off-by: Zach Steindler <[email protected]>
@woodruffw woodruffw merged commit 2a930eb into sigstore:main Sep 21, 2023
3 checks passed
@woodruffw
Copy link
Member

Thanks @steiza!

@jku jku mentioned this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants