Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundle tests to increase coverage of tlog entries #98

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

steiza
Copy link
Member

@steiza steiza commented Aug 18, 2023

Closes #97

Summary

Cover inclusion proofs that don't include the log entry, as well as a different public key in the canonicalized body.

Release Note

NONE

Documentation

N/A

Add bundle tests to cover tlog entries.  Cover inclusion proofs that don't include the log entry, as well as a different public key in the canonicalized body.

Signed-off-by: Zach Steindler <[email protected]>
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@woodruffw woodruffw merged commit 6c958ac into sigstore:main Aug 21, 2023
3 checks passed
@jku jku mentioned this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional bundle tests focused on tlog entries
2 participants