Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Update dependencies #76

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

GnomedDev
Copy link
Contributor

Gets rid of these ancient dep versions, sadly this doesn't fully kill syn 1 (which is my goal) due to the shorthand dep but I have opened an issue over there (although I'm a little concerned about it's usage, idiomatic Rust simply makes a field public instead of a getter/setter pair).

Copy link
Owner

@sile sile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you 👍

@sile
Copy link
Owner

sile commented Sep 6, 2024

although I'm a little concerned about it's usage, idiomatic Rust simply makes a field public instead of a getter/setter pair

That sounds reasonable.
At the moment, I'm not entirely sure that "making a field public" is the best approach for this crate.
However, I am open to reviewing a PR that removes the shorthand dependency (if you want).

@sile sile merged commit dbf26f6 into sile:master Sep 6, 2024
3 checks passed
@GnomedDev
Copy link
Contributor Author

GnomedDev commented Sep 6, 2024

I was looking at removing the shorthand dep, but it's a major amount of work as it is used all over this library. Getters can be useful for read-only public access, but setters are only needed rarely when there are preconditions to be upheld.

@GnomedDev GnomedDev deleted the update-deps branch September 6, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants