Feature/Edit Note make Fullscreen and Delete Button #522 #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mast3Rei
changed the title
Mast3Rei
changed the title
Mast3Rei
changed the title
Mast3Rei
force-pushed
the
feature/edit-notes-fix-fullscreen-add-delete
branch
from
dd98f8e
to
9a7f8dc
Compare
Mast3Rei
force-pushed
the
feature/edit-notes-fix-fullscreen-add-delete
branch
from
d48909f
to
678a983
Compare
|
@Mast3Rei When a user adds a note, it shouldn't go to an empty dialog with the pencil. 
|
Mast3Rei
force-pushed
the
feature/edit-notes-fix-fullscreen-add-delete
branch
2 times, most recently
from
3adab3e
to
6ce4a4f
Compare
chrisvire
reviewed
Aug 15, 2024
src/lib/components/NoteDialog.svelte
Outdated
|
|
||
| export function showModal() { | ||
| export async function showModal() { |
There was a problem hiding this comment.
There is no await, so it doesn't need to be async.
… and DeleteIcon for saving and deleting notes; added a route in /notes/+page.svelte to the edit route
…-screen editor; fixed issue with adding new note
Modify NoteDialog.svelte and note.ts to handle create notes better; implement history.back in /note/edit/[noteid]/+page.svelte
Cleanup in /notes/edit/[noteid]/+page.svelte and+page.js, and static folder
Temporary fix to navigate directly to adding a new note and see an 'Add Note' title; requires additional fixes
A new path called 'routes/notes/new' is created to handle the functionality of adding a new note properly so that it does not get saved in the database until the save button is selected
Removes unnecessary code and comments, and makes it so the textselection only leads to creating a new note
chrisvire
force-pushed
the
feature/edit-notes-fix-fullscreen-add-delete
branch
from
8ad0750
to
4991fab
Compare
|
The title is small?
|
|
What size text should the new note textarea use? Is it the body size? |
chrisvire
requested changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and DeleteIcon for saving and deleting notes; added a route in /notes/+page.svelte to the edit route; attempted to redirect the in-text note editor pop-up to the fullscreen editor when the pencil icon is clicked