fix: better colon handling in slug

sillsdev · Jul 26, 2022 · b4a0a39 · b4a0a39
1 parent cb19125
commit b4a0a39
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/NotionPage.ts b/src/NotionPage.ts
@@ -99,7 +99,9 @@ export class NotionPage {
     if (explicitSlug) return explicitSlug;
     return encodeURIComponent(
       this.nameOrTitle.toLowerCase().replaceAll(" ", "-")
-    );
+    )
+      .replaceAll("%3A", "-")
+      .replaceAll("--", "-");
   }
   public get keywords(): string | undefined {
     return this.getPlainTextProperty("Keywords", "");

diff --git a/src/pull.ts b/src/pull.ts
@@ -169,7 +169,7 @@ async function outputPage(page: NotionPage) {
   let frontmatter = "---\n";
   frontmatter += `title: ${page.nameOrTitle.replaceAll(":", "&#58;")}\n`; // markdown can't handle the ":" here
   frontmatter += `sidebar_position: ${currentSidebarPosition}\n`;
-  frontmatter += `slug: ${page.slug.replaceAll(":", "-") ?? ""}\n`; // markdown can't handle the ":" or "&#58;" here
+  frontmatter += `slug: ${page.slug ?? ""}\n`;
   if (page.keywords) frontmatter += `keywords: [${page.keywords}]\n`;
 
   frontmatter += "---\n";